-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Support variable substitutions in YAML files #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lp doc for submit_slurm
…string format specifier
valmar
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides a way for users to specify input parameters in terms of other parameters (or environment variables) directly from the configuration YAML file. It extends the use of Pydantic validators to define default values in terms of other parameters to arbitrary combinations specified at run time.
Substitution uses a minimal subset of the Jinja syntax.
{{ other_param }}
{{ $ENV_VAR }}
An example use case would be to define paths in terms of experiment or run number:
This PR also introduces a unified way to introduce early program exits tied to environment variables. These are intended for debug use, where an environment variable can be used to allow program exit (eventually pause) at certain markers in the program.
Checklist
{{ $MY_VAR:04d }}
krtc
import into function - allows running in more standard environments.BaseBinaryParameters
andBinaryTask
toThirdPartyParameters
andThirdPartyTask
PR Type:
Address issues:
Testing
A debug exit point has been set after the variable substitution has been performed. A test YAML file has also been provided, so the output after substitution can be examined by setting a number of environment variables.
The input YAML is as follows:
The following command command can be run to explore the output:
Screenshots