Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Add additional options to override SLURM arguments for JIDSlurmOperator #20

Merged
merged 6 commits into from
May 23, 2024

Conversation

gadorlhiac
Copy link
Collaborator

@gadorlhiac gadorlhiac commented Apr 23, 2024

Description

This PR gives DAG operators more control to override certain passed SLURM arguments. It also separates the substitution process into a separate method.

Checklist

  • Provide a max_nodes option to the JIDSlurmOperator to control across how many nodes a job will be split on.
  • Separate out the SLURM argument substitutions into a separate method.
  • Add max_nodes=1 to relevant Tasks, i.e., CrystFEL software which should only be run on one node.
  • Update documentation
  • Handle case where ntasks is not passed. Default to 1 core (properly). Previously would just substitute the value 1, with no flag.

PR Type:

  • New feature/Enhancement

Address issues:

  • NA

Testing

Screenshots

@gadorlhiac gadorlhiac marked this pull request as ready for review May 14, 2024 16:56
@gadorlhiac gadorlhiac requested a review from valmar May 14, 2024 16:56
Copy link
Contributor

@valmar valmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK. Just one question: currently it looks like the _sub_overridable_argument explicitely will work only for max_cores not for generic options. Is this by design? Do we anticipate overriding anything else?

@valmar valmar merged commit c29b66f into slac-lcls:dev May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants