-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning up dead code #156
Conversation
…ethods, lint some files
@mcoughlin any idea why the CI doesn't run by default? |
btw might want to retire 3.8 testing in favor of 3.12, or just add 3.12 |
tests not working locally either (incorrect imports of MOCpy in a few places). Fixing it rn |
I found myself having to remove a lot of stuff that did seem relevant in A little odd, not sure what it does |
moc_keeps was originally intended to track which pixels we should always observe, even in case of incrementing the telescopes where we observe and then remove a region. However, I don't think we really use it, so it could be safely ripped out. |
let me know if you've experienced that before, no idea how to fix it |
ok some unexistent CI runs where set in the branch rules. Removed that but still not running. Looks like there is a schedule set in the CI, maybe that's why? Like it only runs it at a specific time so these can't run? |
Idk I would have thought I copied this from skyportal but @robertdstein had tried to improve this. |
ah... github had turned off the CI on this repo for lack of activity... except it's not really clearly flagged... |
Had to resolve some conflicts with main @mcoughlin, and some of them deleted some code which I didn't, so might want to look at my latest commit to double check that. Otherwise, this should be mergeable once green :) |
@Theodlz sorry a few more conflicts maybe. |
@mcoughlin should be all good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Theodlz
Jokes aside, this PR does a few things:
The reviewer should carefully test this, but the changes should be very minimal