Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 1, 2, 4 size H100's to GCP #4456

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

sethkimmel3
Copy link
Contributor

@sethkimmel3 sethkimmel3 commented Dec 10, 2024

Adds 1, 2, and 4 sized instance types for H100's to GCP catalog

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sethkimmel3 for adding the support! Could you also help adding those GPUs in our catalog fetcher here and see if the catalog fetcher can correctly fetch those catalogs for H100 with less quantity?

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sethkimmel3 for the quick fix! LGTM.

@Michaelvll Michaelvll merged commit 02fb8bd into skypilot-org:master Dec 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants