Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s] Fix show-gpus when running with incluster auth #4452

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

romilbhardwaj
Copy link
Collaborator

sky show-gpus when running with in-cluster auth would previously return empty list since context=None was not handled correctly. This PR fixes it to use in-cluster auth when context=None in sky show-gpus.

Tested:

  • Base case - when kubeconfig does not exist on local laptop (context will be None, not incluster = should return no GPUs)
  • server from restapi branch running in a k8s pod; both sky show-gpus and sky show-gpus L4work (context will be None but now we handle in-cluster case correctly).

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @romilbhardwaj !

@romilbhardwaj romilbhardwaj merged commit bc4a42e into master Dec 11, 2024
19 checks passed
@romilbhardwaj romilbhardwaj deleted the k8s_fix_incontext_showgpus branch December 11, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants