[azure] support for existing subnet #4417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkukral
force-pushed
the
azure_subnet
branch
4 times, most recently
from
4619a42 to
9a5f71c
Compare
tomkukral
changed the title
cblmemo
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Thanks @tomkukral for contributing this! It would be really helpful. Left some discussions :)
| # SkyPilot created new vnet and subnet by default but it will reuse exisiting subnet if specified. | ||
| subnet_id: /subscriptions/subscription-id/resourceGroups/resource-group-name/providers/Microsoft.Network/virtualNetworks/vnet-name/subnets/subnet-name | ||
|
|
||
| # Should instances be assigned private IPs only? (optional) |
| # When set to true, SkyPilot will only use private subnets to launch nodes and won't expose | ||
| # instances on public IP addresses. | ||
| # Reference: https://learn.microsoft.com/en-us/azure/virtual-network/virtual-network-manage-subnet?tabs=azure-portal | ||
| # Default: false. |
There was a problem hiding this comment.
maybe move this right after the (optional) line?
| "existingSubnet": { | ||
| "type": "string", | ||
| "metadata": { | ||
| "description": "Existing subnet id to use." |
sky/provision/azure/config.py
Outdated
| # choose a random subnet, skipping most common value of 0 | ||
| random.seed(cluster_id) | ||
| subnet_mask = f'10.{random.randint(1, 254)}.0.0/16' | ||
| if subnet_id == '': |
There was a problem hiding this comment.
why do we change this from subnet_mask is missing, to subnet_id is missing? what is the relation between these two variables?
sky/provision/azure/config.py
Outdated
| @@ -86,6 +86,8 @@ def bootstrap_instances( | |||
| 'use_external_resource_group field') | |||
| use_external_resource_group = provider_config['use_external_resource_group'] | |||
|
|
|||
| subnet_id = provider_config.get('subnet_id', '') | |||
There was a problem hiding this comment.
nit: can we use None instead of empty string to indicate not specified? same for the arm template.
This change is adding possibility to configure azure.subnet_id fixes skypilot-org#2910
tomkukral
force-pushed
the
azure_subnet
branch
from
4bbe358 to
2b44133
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is adding possibility to configure
azure.subnet_id. It will reuse existing subnet if specified.Fixes #2910
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh