Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][Disk] High disk tier on Azure #3921

Merged
merged 4 commits into from
Sep 7, 2024
Merged

[Core][Disk] High disk tier on Azure #3921

merged 4 commits into from
Sep 7, 2024

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Sep 6, 2024

Added a high disk tier for Azure. The new tier uses P50 on Premium_LRS.

Discussions

  • For disk size >= 4096, it will automatically select P50 and this does not make any difference b/t medium and high tier.
  • Investigate if update the disk performance can be done on python API.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • sky launch --cloud azure --disk-tier high and manually check the console
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick support of high disk tier for Azure @cblmemo! Several comments.

sky/clouds/azure.py Outdated Show resolved Hide resolved
sky/provision/azure/instance.py Outdated Show resolved Hide resolved
@cblmemo cblmemo enabled auto-merge September 7, 2024 01:54
@cblmemo cblmemo added this pull request to the merge queue Sep 7, 2024
Merged via the queue into master with commit 363f27b Sep 7, 2024
20 checks passed
@cblmemo cblmemo deleted the az-high-disk-tier branch September 7, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants