[DigitalOcean] droplet integration

[asaiacai]

This adds digital ocean droplets to the sky.

Tested (run the relevant ones):

• Code formatting: bash format.sh
• All smoke tests: pytest tests/test_smoke.py --do

[moinnadeem]

@asaiacai I would be really interested in using this work -- do you know when you might be able to land this PR?

[asaiacai]

Hello! I’m aiming for this to land in next two weeks providing testing goes smoothly. Stay tuned!

[asaiacai]

@Michaelvll i think this PR is finally ready, once you have a free moment! I've currently disabled tests for gpu droplets as they are still in early access, but I think I got the remaining tests to work on normal CPU droplets fine. Let me know if you find any issues.

[asaiacai]

also this catalog update is required to pass the sky serve requests since I added cheaper 2vcpu instances.

skypilot-org/skypilot-catalog#83

[cblmemo]

Thanks for this amazing work @asaiacai ! This would be very helpful. Left some discussions ;)

[strict-type]

Hi @asaiacai , I'm considering adding a new cloud provider to Sky and was reviewing the Google Doc linked in Sky's documentation. However, I couldn't find any guidance on setting up test files for this. I looked through the test folder and the GitHub Actions file, but I'm unclear about how cloud credentials are configured for tests in GitHub CI. Could you help me understand how Sky sets up the tests for CI? I didn't see any references to GitHub secrets in the actions file, so I feel like I'm missing some information.

cc: @cblmemo

[cblmemo]

Hi @asaiacai , I'm considering adding a new cloud provider to Sky and was reviewing the Google Doc linked in Sky's documentation. However, I couldn't find any guidance on setting up test files for this. I looked through the test folder and the GitHub Actions file, but I'm unclear about how cloud credentials are configured for tests in GitHub CI. Could you help me understand how Sky sets up the tests for CI? I didn't see any references to GitHub secrets in the actions file, so I feel like I'm missing some information.

cc: @cblmemo

Hi @strict-type , not all tests is included in the github actions, and all tests in github actions does not requires cloud credentials. All tests require credentials is located in test_smoke.py, which needs to be ran locally on developer's laptop and leverage their local credentials.

[strict-type]

Hi @asaiacai , I'm considering adding a new cloud provider to Sky and was reviewing the Google Doc linked in Sky's documentation. However, I couldn't find any guidance on setting up test files for this. I looked through the test folder and the GitHub Actions file, but I'm unclear about how cloud credentials are configured for tests in GitHub CI. Could you help me understand how Sky sets up the tests for CI? I didn't see any references to GitHub secrets in the actions file, so I feel like I'm missing some information.
cc: @cblmemo

Hi @strict-type , not all tests is included in the github actions, and all tests in github actions does not requires cloud credentials. All tests require credentials is located in test_smoke.py, which needs to be ran locally on developer's laptop and leverage their local credentials.

Thank you for your response! Now, I've a better clarity on testing.

[asaiacai]

@cblmemo if you have a spare cycle

[cblmemo]

@cblmemo if you have a spare cycle

Hi @asaiacai, It seems like the CI is failing. Could you help take a look at what is happening here?

[cblmemo]

Thanks @asaiacai ! Mostly looks good to me. Left 2 nits. If the CI and smoke test passed, it should be ready to go!

[asaiacai]

CI broken due to catalog. i pushed a fix here.
skypilot-org/skypilot-catalog#103

[cblmemo]

Thanks @asaiacai ! LGTM. Lemme know if all smoke test is passed, and we can merge it!

[cg505]

You can readd this to the new sky/setup_files/dependencies.py. Sorry for the merge conflict.