Change cloud implementation feature name

skypilot-org · Dec 10, 2024 · 01dc978 · 01dc978
1 parent 74bcb7d
commit 01dc978
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/sky/clouds/cloud.py b/sky/clouds/cloud.py
@@ -46,7 +46,7 @@ class CloudImplementationFeatures(enum.Enum):
     STORAGE_MOUNTING = 'storage_mounting'
     HOST_CONTROLLERS = 'host_controllers'  # Can run jobs/serve controllers
     AUTO_TERMINATE = 'auto_terminate'  # Pod/VM can stop or down itself
-    ENVOY = 'envoy_load_balancer'
+    HOST_ENVOY_LOAD_BALANCER = 'host_envoy_load_balancer'
 
 
 class Region(collections.namedtuple('Region', ['name'])):

diff --git a/sky/clouds/kubernetes.py b/sky/clouds/kubernetes.py
@@ -69,9 +69,10 @@ class Kubernetes(clouds.Cloud):
                                                              'tiers are not '
                                                              'supported in '
                                                              'Kubernetes.',
-        clouds.CloudImplementationFeatures.ENVOY: 'Envoy load balancer is not '
-                                                  'supported on Kubernetes '
-                                                  'controllers.'
+        clouds.CloudImplementationFeatures.HOST_ENVOY_LOAD_BALANCER:
+            'Envoy load balancer is not '
+            'supported on Kubernetes '
+            'controllers.'
     }
 
     IMAGE_CPU = 'skypilot:custom-cpu-ubuntu-2004'

diff --git a/sky/serve/core.py b/sky/serve/core.py
@@ -165,7 +165,9 @@ def up(
                 if resource.cloud is None:
                     continue
 
-                requested_features = {clouds.CloudImplementationFeatures.ENVOY}
+                requested_features = {
+                    clouds.CloudImplementationFeatures.HOST_ENVOY_LOAD_BALANCER
+                }
                 resource.cloud.check_features_are_supported(
                     resource, requested_features)