Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with page-alignment of RW/RX page sizes #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jam1garner
Copy link
Member

Requires testing before merge.

Things to test:

  1. Ensure this isn't a reversion by testing that A64HookFunction works
  2. Ensure that this actually fixes modifying .text/.rodata along page boundaries resulting in a lower offset-in-page of the end of the buffer than the start of the buffer.

For example:

rx = 0xFFC;
size = 0x8;

In this instance, the 4 bytes on the second page would not be properly included in the ControlledPages and will crash if you attempt to write to it due to the second page not being mapped.

@jam1garner jam1garner requested a review from jugeeya April 23, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant