SK-1308 Fix bug in Get method in Python SDK #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix bug when calling Get method with options tokens as true. - Remove redundant import statements from client file. - Add missing validation case for Get method.
skyflow-vivek
force-pushed
the
SK-1308-fix-bug-when-calling-get-with-options-true
branch
from
7f5f868 to
19d9668
Compare
- Update CHANGELOG - Fixed wrong info log in case of partial success in get method
skyflow-vivek
force-pushed
the
SK-1308-fix-bug-when-calling-get-with-options-true
branch
from
ea72b48 to
6e04d3b
Compare
|
The uncovered lines are covered in E2E tests. |
yaswanth-pula-skyflow
approved these changes
Dec 7, 2023
skyflow-amith
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SK-1308 Fix bug in Get method in Python SDK