Skip to content

Commit

Permalink
SK-1622: resolved feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
saileshwar-skyflow committed Sep 18, 2024
1 parent 000ddcd commit f682e59
Show file tree
Hide file tree
Showing 15 changed files with 10 additions and 18 deletions.
2 changes: 1 addition & 1 deletion v2/skyflow/client/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
from ._skyflow import Skyflow
from .skyflow import Skyflow
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
from typing import List, Optional
from v2.skyflow.management.config import ManagementConfig
from v2.skyflow.utils import LogLevel
from v2.skyflow.vault.config import VaultConfig, CredentialsConfig, ConnectionConfig


class Skyflow:
def __init__(self,
vault_config: List[VaultConfig],
skyflow_credentials: Optional[CredentialsConfig],
skyflow_credentials: Optional[CredentialsConfig] = None,
connection_config: Optional[List[ConnectionConfig]] = None,
log_level: Optional[LogLevel] = None):
self.vault_config = vault_config
Expand Down Expand Up @@ -47,7 +46,7 @@ def update_connection_config(self, connection_config: ConnectionConfig):
def update_log_level(self, log_level: LogLevel):
pass

def log_level(self, log_level: str):
def set_log_level(self, log_level: str):
pass

def build(self):
Expand Down
3 changes: 0 additions & 3 deletions v2/skyflow/data/__init__.py

This file was deleted.

1 change: 1 addition & 0 deletions v2/skyflow/utils/_validations/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from ._validations import Validations
File renamed without changes.
2 changes: 1 addition & 1 deletion v2/skyflow/vault/controller/_audit.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
class Audit:
class AuditController:
#members
def __init__(self):
pass
Expand Down
2 changes: 1 addition & 1 deletion v2/skyflow/vault/controller/_bin_look_up.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
class BinLookUp:
class BinLookUpController:
#members
def __init__(self):
pass
Expand Down
2 changes: 1 addition & 1 deletion v2/skyflow/vault/controller/_connections.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
class Connection:
class ConnectionController:
#members
def __init__(self):
pass
Expand Down
5 changes: 0 additions & 5 deletions v2/skyflow/vault/controller/_detect.py

This file was deleted.

2 changes: 1 addition & 1 deletion v2/skyflow/vault/controller/_vault.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
class Vault:
class VaultController:
#members
def __init__(self):
pass
Expand Down
2 changes: 1 addition & 1 deletion v2/skyflow/vault/model/data/request/__init__.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
from ._detokenize import DetokenizeRequest
from ._insert import InsertRequest
from .insert import InsertRequest
2 changes: 1 addition & 1 deletion v2/skyflow/vault/model/data/response/__init__.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
from _insert import InsertResponse
from insert import InsertResponse
from _detokenize import DetokenizeResponse

0 comments on commit f682e59

Please sign in to comment.