Skip to content

Commit

Permalink
SK-1731: Updated shared build yml file
Browse files Browse the repository at this point in the history
  • Loading branch information
saileshwar-skyflow committed Nov 11, 2024
1 parent fb7f739 commit c9632d0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/internal-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,5 @@ jobs:
with:
ref: ${{ github.ref_name }}
is-internal: true
secrets:
jfrog-username: ${{ secrets.JFROG_USERNAME }}
jfrog-password: ${{ secrets.JFROG_PASSWORD }}
secrets: inherit

4 changes: 2 additions & 2 deletions .github/workflows/shared-build-and-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ jobs:
- name: Build and Publish to JFrog Artifactory
if: ${{ inputs.is-internal }}
env:
TWINE_USERNAME: ${{ inputs.jfrog-username }}
TWINE_PASSWORD: ${{ inputs.jfrog-password }}
TWINE_USERNAME: ${{ secrets.JFROG_USERNAME }}
TWINE_PASSWORD: ${{ secrets.JFROG_PASSWORD }}
run: |
# Check if TWINE_USERNAME and TWINE_PASSWORD are empty
if [ -z "$TWINE_USERNAME" ]; then
Expand Down

0 comments on commit c9632d0

Please sign in to comment.