Joe got carried away when adding a note about InvokeConnections limitations for [CUST-2328] #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstjoe
commented
Apr 29, 2024
jstjoe
commented
Apr 29, 2024
jstjoe
commented
Apr 29, 2024
jstjoe
commented
Apr 30, 2024
jstjoe
commented
Apr 30, 2024
jstjoe
commented
Apr 30, 2024
manny-silva
requested changes
May 3, 2024
Co-authored-by: manny-silva <[email protected]>
…w-node into joe-2024-04-26
Co-authored-by: manny-silva <[email protected]>
think that's the last of them Co-authored-by: manny-silva <[email protected]>
|
I think it's ready for a review @manny-silva 🙏 |
manny-silva
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added line about limitations to Connections error response per customer feedback, and then...
redid intro / title.
reorganized headers, including elevating some and moving Authentication / Authorization to the end.
hid some examples as
details(expandable sections).cleaned up some formatting.
changed
clientvariable tovaultconsistently across README for style and readability e.g.vault.insert()vault.get()Let me know if I can help contextualize or fix anything. I know I changed a lot in this one PR, and a lot in one commit.
cc @manny-silva @ram7muthu