SK-1439 fix multiple unique column_names in get record request. #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saketh-skyflow
approved these changes
Jan 25, 2024
skyflow-shashank-prajapati
approved these changes
Jan 25, 2024
roshmik
reviewed
Jan 25, 2024
| @@ -1930,6 +1941,78 @@ describe('get method with options', () => { | |||
| }); | |||
|
|
|||
|
|
|||
| }); | |||
|
|
|||
| test('get method should send request url with single column name for multiple column value', (done) => { | |||
There was a problem hiding this comment.
What is the difference between the two tests? Somehow did not spot the different.
| } | ||
| }); | ||
|
|
||
| const response = skyflow.get(getByIdWithValidMultipleUniqColumnOptions,{encodeURI:false}); |
There was a problem hiding this comment.
@roshmik {encode: false} is the option we have added in this test and not was in the above test.
My bad, didn't add it in description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.