SK-1317 Add continue on error in batch Insert

- Removed requestId from responses where not required
skyflowapi · Jan 11, 2024 · 578a24c · 578a24c
1 parent 3bfb43d
commit 578a24c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/src/vault-api/Controller.ts b/src/vault-api/Controller.ts
@@ -326,7 +326,8 @@ class Controller {
           body: config.requestBody,
           headers: { 'x-skyflow-authorization': res, 'content-type': ContentType.APPLICATIONORJSON,...toLowerKeys(config.requestHeader) },
         });
-        invokeRequest.then((response) => {
+        invokeRequest.then((response: any) => {
+          delete response.requestId;
           rootResolve(response);
         }).catch((err) => {
           rootReject({ errors: [err] });

diff --git a/src/vault-api/core/Collect.ts b/src/vault-api/core/Collect.ts
@@ -65,9 +65,11 @@ export const constructInsertRecordResponse = (
         }
       } else {
         failureObjects.push({
-          code: status,
-          ddescription: `${body['error']} - requestId: ${responseBody.requestId}`,
-          request_index: index,
+          error: {
+            code: status,
+            description: `${body['error']} - requestId: ${responseBody.requestId}`,
+            request_index: index,
+          }
         })
       }
     })

diff --git a/src/vault-api/core/Delete.ts b/src/vault-api/core/Delete.ts
@@ -47,6 +47,7 @@ export const deleteRecordsBySkyflowID = (
           )
             .then(
               (response: any) => {
+                delete response.requestId;
                 deleteResponse.push(response);
               },
               (cause: any) => {