GUARD-3077 Shopify-Version-Update-To-2023-04 (#38)

GUARD-3077 Shopify version updated to 2023-04, outdated versions removed, comments to failed integration tests added
skuvault-integrations · Oct 20, 2023 · 56f97f8 · 56f97f8
1 parent 4a12a23
commit 56f97f8
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 5 deletions.
diff --git a/.build.ps1 b/.build.ps1
@@ -76,7 +76,7 @@ task NuGet Package, Version, {
 <package>
 	<metadata>
 		<id>$project_name</id>
-		<version>$Version</version>
+		<version>$Version-alpha</version>
 		<authors>SkuVault</authors>
 		<owners>SkuVault</owners>
 		<projectUrl>https://github.com/agileharbor/$project_name</projectUrl>

diff --git a/src/Global/GlobalAssemblyInfo.cs b/src/Global/GlobalAssemblyInfo.cs
@@ -22,4 +22,4 @@
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
 
-[ assembly : AssemblyVersion( "1.9.1.0" ) ]
+[ assembly : AssemblyVersion( "1.11.0.0" ) ]
diff --git a/src/ShopifyAccess/Models/Configuration/Command/ShopifyApiVersion.cs b/src/ShopifyAccess/Models/Configuration/Command/ShopifyApiVersion.cs
@@ -9,9 +9,8 @@ public sealed class ShopifyApiVersion
 	{
 		private readonly string _versionCode;
 
-		public static readonly ShopifyApiVersion V2022_07 = new ShopifyApiVersion( "2022-07" );
-		public static readonly ShopifyApiVersion V2022_10 = new ShopifyApiVersion( "2022-10" );
 		public static readonly ShopifyApiVersion V2023_01 = new ShopifyApiVersion( "2023-01" );
+		public static readonly ShopifyApiVersion V2023_04 = new ShopifyApiVersion( "2023-04" );
 
 		private ShopifyApiVersion( string versionCode )
 		{

diff --git a/src/ShopifyAccessTests/ShopifyAccessTests/BaseTests.cs b/src/ShopifyAccessTests/ShopifyAccessTests/BaseTests.cs
@@ -11,7 +11,7 @@ namespace ShopifyAccessTests
 {
 	public class BaseTests
 	{
-		protected static readonly ShopifyApiVersion ApiVersion = ShopifyApiVersion.V2023_01;
+		protected static readonly ShopifyApiVersion ApiVersion = ShopifyApiVersion.V2023_04;
 		protected readonly IShopifyFactory ShopifyFactory = new ShopifyFactory( ApiVersion );
 		protected ShopifyClientCredentials _clientCredentials;
 		protected IShopifyService Service;

diff --git a/src/ShopifyAccessTests/ShopifyAccessTests/Users/UsersTests.cs b/src/ShopifyAccessTests/ShopifyAccessTests/Users/UsersTests.cs
@@ -5,6 +5,10 @@
 
 namespace ShopifyAccessTests.Users
 {
+	/// <summary>
+	/// Note: These tests may fails for our sandbox account as the User resource is available for private apps and custom apps installed 
+	/// on Shopify Plus stores (see https://shopify.dev/docs/api/admin-rest/2023-04/resources/user)
+	/// </summary>
 	[ TestFixture ]
 	public class UsersTests : BaseTests
 	{