Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds calculation of fee #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adds calculation of fee #20

wants to merge 1 commit into from

Conversation

skopczynska
Copy link
Owner

No description provided.

for (int i = 0; i < accounts.Length; i++)
{
account = accounts[i];
if (account.accountType == Account.PREMIUM || account.accountType == Account.PREMIUM_PLUS) totalFee += .0125 * ( // 1.25% broker's fee
Copy link

@piotr-bak piotr-bak Nov 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would declare the broker's fee as a const upfront (and then reference the const's name in the function) instead of using a magic number of .0125 with the explanation in comment

{
account = accounts[i];
if (account.accountType == Account.PREMIUM || account.accountType == Account.PREMIUM_PLUS) totalFee += .0125 * ( // 1.25% broker's fee
account.principal * Math.pow(account.rate, (account.daysActive / 365.25)) - account.principal); // interest-principal

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use similar approach for 365.25 days of the year referenced here (even though 365.25 is self-descriptive in a way). Also - what about leap years, do they make a difference from the logic's perspective?

{
account = accounts[i];
if (account.accountType == Account.PREMIUM || account.accountType == Account.PREMIUM_PLUS) totalFee += .0125 * ( // 1.25% broker's fee
account.principal * Math.pow(account.rate, (account.daysActive / 365.25)) - account.principal); // interest-principal

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be Math.Pow? (Syntax)

a.principal = 1.0;
a.rate = 0.5;
myAccounts[0] = a;
a = new Account() { principal = 1.5, rate = 0.75 };

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new values assigned to a (that has been just declared/assigned previously)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants