Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User setting 페이지 이동 #360

Merged
merged 3 commits into from
Apr 12, 2022
Merged

User setting 페이지 이동 #360

merged 3 commits into from
Apr 12, 2022

Conversation

Kohminchae
Copy link
Contributor

#338 유저 프로필: Setting 구현

  • 유저의 setting page를 user-profile 페이지의 탭으로 이동
  • Home의 우측 상단 dropdown에 학생의 경우 My Profile, SuperAdmin과 admin의 경우에는 management 표시됨.

@Kohminchae Kohminchae added the FE Frontend tasks label Mar 30, 2022
@Kohminchae Kohminchae added this to the 유저 페이지 리뉴얼 milestone Mar 30, 2022
@Kohminchae Kohminchae changed the title User/minchae User setting 페이지 이동 Mar 30, 2022
@jimin9038 jimin9038 self-requested a review March 30, 2022 15:22
Copy link
Member

@jimin9038 jimin9038 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 하나만 고치고 바로 머지해주세요~~ 👍

<div class="container">
<div class="setting-main font-bold">
<div class="section-title logo-title font-bold">
<div class="profile-setting">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

css에서 .container 삭제해줘도 될 것 같아요(line 249)

@jimin9038 jimin9038 merged commit c81408d into dev/user-profile Apr 12, 2022
@jimin9038 jimin9038 deleted the user/minchae branch April 12, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE Frontend tasks
Projects
No open projects
Status: Complete🚀
Development

Successfully merging this pull request may close these issues.

2 participants