Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migration from zod to valibot #2286

Merged
merged 5 commits into from
Jan 14, 2025
Merged

chore: migration from zod to valibot #2286

merged 5 commits into from
Jan 14, 2025

Conversation

eunnbi
Copy link
Contributor

@eunnbi eunnbi commented Jan 9, 2025

Description

zod를 valibot로 마이그레이션합니다.

Migration guide: https://valibot.dev/guides/migrate-from-zod/

번들 크기 비교 스샷 (2025.01.09 오후 1시 기준) - zod 사용하는 페이지마다 First Load JS가 약 10KB 씩 줄어듦

  • /admin/contest/create
  • /admin/contest/[contestId]/edit
  • /admin/problem/create
  • /admin/problem/[problemId]/edit
  • /settings

Zod 사용했을 때
스크린샷 2025-01-09 오후 1 51 34

Valibot 사용했을 때
스크린샷 2025-01-09 오후 1 48 37

Additional context


Before submitting the PR, please make sure you do the following

@eunnbi eunnbi requested a review from B0XERCAT January 9, 2025 04:59
@eunnbi eunnbi self-assigned this Jan 9, 2025
@eunnbi eunnbi removed the request for review from B0XERCAT January 9, 2025 04:59
@eunnbi eunnbi marked this pull request as ready for review January 9, 2025 05:05
@eunnbi eunnbi removed the request for review from jihorobert January 11, 2025 03:04
Copy link
Member

@B0XERCAT B0XERCAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍

@eunnbi eunnbi merged commit 53f5bac into main Jan 14, 2025
9 checks passed
@eunnbi eunnbi deleted the chore/valibot branch January 14, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants