Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(fe): delete the title if no data #2273

Merged
merged 2 commits into from
Jan 5, 2025
Merged

style(fe): delete the title if no data #2273

merged 2 commits into from
Jan 5, 2025

Conversation

Clover229
Copy link
Contributor

@Clover229 Clover229 commented Jan 2, 2025

Description

closes TAS-807

Contest/Problem 없을 시 타이틀이 보이지 않도록 수정하였습니다.

화면 캡처 2025-01-02 175923
Contest/Problem 있을 때의 사진입니다.

화면 캡처 2025-01-02 175814
Problem만 있을 때의 사진입니다.

화면 캡처 2025-01-02 175601
둘 다 없을 때의 사진입니다.

Additional context

  • 둘 다 없을 때 어색해 보여서 Contest/Problem 이 없을 시 제목 밑에 No Contest / No Problem 이 있으면 좋지 않을까 제안해봅니다~

Before submitting the PR, please make sure you do the following

@Clover229 Clover229 requested a review from dayeoni January 2, 2025 07:24
Copy link

@dayeoni
Copy link
Contributor

dayeoni commented Jan 2, 2025

LGTM

  • description 작성 시 task 설명을 스크린샷과 함께 작성해주면 더 좋을거 같습니다!

Copy link
Contributor

@dayeoni dayeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Clover229 Clover229 merged commit e2b7649 into main Jan 5, 2025
8 checks passed
@Clover229 Clover229 deleted the t807-delete-title branch January 5, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done ✔️
Development

Successfully merging this pull request may close these issues.

4 participants