Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fe): confirm modal when leaving settings page #2261

Merged
merged 18 commits into from
Jan 2, 2025

Conversation

jihorobert
Copy link
Contributor

@jihorobert jihorobert commented Dec 19, 2024

Description

  • Settings 페이지 이탈 시 Confirm Modal 디자인대로 구현
    • 기존에는 window 디폴트 모달창 이용
  • Shadcn AlertDialog -> AlertDialogOverlay 에 darkMode 선택 여부 기능 추가해서
    • true일 경우 배경을 어둡게
스크린샷 2024-12-19 오후 1 33 38
  • false일 경우 배경을 밝게 (Default)
스크린샷 2024-12-19 오후 1 36 13 -> 코드당에서는 밝은 모드를 더 쓰는 것 같음

closes TAS-1113


Before submitting the PR, please make sure you do the following

Copy link

@jihorobert jihorobert merged commit b945f8e into main Jan 2, 2025
7 of 8 checks passed
@jihorobert jihorobert deleted the t1113-settings-confirm-modal branch January 2, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done ✔️
Development

Successfully merging this pull request may close these issues.

5 participants