Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(fe): refactor editor description #2112

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

refactor(fe): refactor editor description #2112

wants to merge 7 commits into from
+309 −320

Conversation

youznn
Copy link
Member

@youznn youznn commented Sep 23, 2024 •
edited
Loading

Description

  • Editor Description 페이지를 리팩토링 했습니다.
  • Sample field에서 사용하는 copy 관련 함수들과 태그들을 뭉쳐서 EditorSampleField로 분리했습니다.
  • ReferenceDialog를 분리했습니다.

Additional context

  • 현재 eslint 업데이트로 인해서 연산자에서 에러가 발생합니다. 임시로 eslint-disable-next-line로 처리해 주었는데 추후 확인이 필요할 것 같습니다.

closes TAS-933

Before submitting the PR, please make sure you do the following

@youznn youznn self-assigned this Sep 23, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
codedang ✅ Ready (Inspect) Visit Preview Oct 7, 2024 2:35am

@notion-workspace Notion Workspace
Copy link

EditorDescription 리팩토링

@youznn youznn marked this pull request as ready for review September 23, 2024 07:14
eunnbi
eunnbi reviewed Sep 23, 2024
View reviewed changes
apps/frontend/components/EditorSampleField.tsx Outdated Show resolved Hide resolved
apps/frontend/components/EditorSampleField.tsx Outdated Show resolved Hide resolved
apps/frontend/components/EditorSampleField.tsx Outdated Show resolved Hide resolved
@jimin9038
Copy link
Member

coolify 배포를 위해서 닫았다가 열게요.

@jimin9038 jimin9038 closed this Sep 26, 2024
@jimin9038 jimin9038 reopened this Sep 26, 2024
@coolify-skkuding
Copy link

coolify-skkuding bot commented Sep 26, 2024 •
edited
Loading

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2024-09-26 09:19:11 CET

B0XERCAT
B0XERCAT approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@B0XERCAT B0XERCAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🐱

@B0XERCAT
Copy link
Member

B0XERCAT commented Jan 8, 2025

@youznn Conflict만 해결하고 머지해주세요!

@youznn
Copy link
Member Author

youznn commented Jan 8, 2025

@youznn Conflict만 해결하고 머지해주세요!

네 따로 수정할 사항 없으면 해결하고 바로 머지하겠습니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B0XERCAT B0XERCAT B0XERCAT approved these changes

@eunnbi eunnbi eunnbi approved these changes

@jwoojin9 jwoojin9 Awaiting requested review from jwoojin9

@Kohminchae Kohminchae Awaiting requested review from Kohminchae

@juhyeong0505 juhyeong0505 Awaiting requested review from juhyeong0505

@Kimhyojung0810 Kimhyojung0810 Awaiting requested review from Kimhyojung0810

Assignees

@youznn youznn

Labels
💡 feature-client ⛳️ team-frontend
Projects
Codedang
Status: Approved 👌
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@youznn @jimin9038 @B0XERCAT @eunnbi