Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Bruno API docs convention #1275

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Conversation

SH9480P
Copy link
Member

@SH9480P SH9480P commented Jan 30, 2024

Description

closes #1269

2024.1.29 백엔드 회의에서 결정한 Bruno API docs 작성 convention을 코드당 문서에 추가합니다.

Additional context

pnpm docs:dev로 확인 가능합니다.


Before submitting the PR, please make sure you do the following

@SH9480P SH9480P self-assigned this Jan 30, 2024
@SH9480P SH9480P linked an issue Jan 30, 2024 that may be closed by this pull request
3 tasks
Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
codedang ✅ Ready (Inspect) Visit Preview Jan 31, 2024 5:46pm

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 31.7%, saving 7.53 KB.

Filename Before After Improvement Visual comparison
docs/intro/graphql-docs.png 23.76 KB 16.23 KB -31.7% View diff

42 images did not require optimisation.

@SH9480P
Copy link
Member Author

SH9480P commented Jan 31, 2024

@dotoleeoak Github Action check 왜 계속 대기중인가요..?

@dotoleeoak
Copy link
Member

@dotoleeoak Github Action check 왜 계속 대기중인가요..?

그러게요... 이유는 모르겠어요 🤷‍♂️
일단 임의로 메인 브랜치 머지해서 CI 실행시켰어요

@dotoleeoak dotoleeoak merged commit 2069722 into main Jan 31, 2024
11 checks passed
@dotoleeoak dotoleeoak deleted the 1269-add-bruno-docs-convention branch January 31, 2024 17:53
cho-to pushed a commit that referenced this pull request Feb 5, 2024
* docs: add Bruno convention

* Optimised images with calibre/image-actions

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jaemin Choi <[email protected]>
cho-to pushed a commit that referenced this pull request Feb 19, 2024
* docs: add Bruno convention

* Optimised images with calibre/image-actions

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jaemin Choi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bruno API 작성 convention 추가
2 participants