Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fe): cover style #1111

Merged
merged 1 commit into from
Jan 2, 2024
Merged

fix(fe): cover style #1111

merged 1 commit into from
Jan 2, 2024

Conversation

jihorobert
Copy link
Contributor

Description

  • Cover image 변경
    • bgColor props으로 tailwindCss의 color class 받아서 적용
    • js doc 작성함
    • height 200px로 바꿈

close #1108

Before submitting the PR, please make sure you do the following

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
codedang ✅ Ready (Inspect) Visit Preview Jan 2, 2024 6:43am

@jihorobert jihorobert merged commit 28417f9 into main Jan 2, 2024
12 checks passed
@jihorobert jihorobert deleted the 1108-change-cover-image branch January 2, 2024 06:46
aintbe pushed a commit that referenced this pull request Jan 3, 2024
youznn added a commit that referenced this pull request Jan 15, 2024
* feat: set up page

* feat(fe): scaffolding colums and rows in table

* feat(fe): set fixed width, add responsiveness, include hover effect

* feat(fe): implement sorting

* chore(fe): undo sorting button

* chore(fe): change switch color to primary color

* feat(fe): implement tag switch, keyword search bar and the number of problems

* chore(fe): add font weight 700, 800

* fix(fe): cover style (#1111)

* feat(fe): change toaster to sonner (#1112)

* feat(fe): fixed notice (#1116)

* feat(fe): fixed notice

* fix: lockfile version

* feat(fe): add writer section at notice table (#1119)

* fix: auto layout to fixed layout

* feat(fe): notice table add writer column

---------

Co-authored-by: dayongkr <[email protected]>

* feat(be): implement problem title search api (#1122)

* fix(be): fix prisma schema to enable full-text search using preview feature

* feat(be): implement problem title search using full-text search

* fix(be): change from full-text search to exact match using prisma contains option

* docs(be): update bruno docs

* fix(be): add todo and fixme comment

* fix(cd): create iam role for ecr push (#1124)

* feat(fe): implement main page (#1075)

* feat(fe): add card component from shadcn

* docs(be): add client contest module api docs (#954)

Co-authored-by: Jaemin Choi <[email protected]>

* feat(be): rename clarification module to announcement (#794)

* feat(be): add annoucecment model to scheme and module to client

* feat(be): implement get announcement methods

* feat(be): implement group controllers

* chore(be): append missing controllers and tc ex

* feat(be): devide into problem and contest announcement

* chore(be): fakerjs installation

* feat(be): test codes - announcements

* fix(be): seeding announcements

* fix(be): prisma query

* fix(be): some to every

* feat(be): implement storing Contest/WorkbookProblem id in order field with graphql (#819)

* feat(be): modify WorkbookProblem and ContestProblem field

각각 DB에서의 id 필드를 order 필드로 수정했습니다.

* feat(be): implement getWorkbookProblems and updateWorkbookProblemsOrder

test(be): add service test codes for getWorkbookProblems and updateWorkbookProblemsOrder

* fix(be): fix return type of workbookproblem resolver

* feat(be): implement storing ContestProblem id in order field

contest-problem resource를 만들어, ContestProblem의 id 값을 order로 설정하여 변경하는 로직을 구현했습니다.

feat(be): implement storing WorkbookProblem id in order field

workbook-problem resource를 만들어, WorkbookProblem의 id 값을 order로 설정하여 변경하는 로직을 구현했습니다.

* chore(be): remove unused import module in admin module
- admin.module.ts에서 안 쓰는 module을 정리했습니다.

* refactor(be): migrate contest/workbook-problem res code to problem res

contest-problem과 workbook-problem res에 있는 코드를 problem res로 migration 했습니다.

* feat(be): implement checking if contest/workbook is in groupId
contest와 workbook이 groupId에 속하는지 확인하는 로직을 추가했습니다.

* test(be): add test code for probem service

contest-problem res와 workbook-problem res에 있던 test code를 problem res로 옮겼습니다.

* chore(be): delete unused res
contest-problem res와 workbook-problem res 삭제

* chore(be): change clarification service code to resolve type error
바뀐 contestProblem db schema의 type error를 resolve하기 위해 코드를 수정했습니다.

*chore(be): change contest service code to resolve type error
바뀐 contestProblem db schema의 type error를 resolve하기 위해 코드를 수정했습니다.

* chore(be): add some comment on the service code

* feat(be): change workbookProblem order update logic

feat(be): chage contestProblem order update logic

* feat(be): add prisma transaction when updating workbook/contestProblems order

test(be): add test for updating workbook/contestProblems order

* feat(be): updateContestProblemsOrder 로직 수정
order 필드는 정수 1부터 시작하도록 수정

* test(be): fix problem service test code
매번 테스트를 하기 전에 stub을 초기화 해주지 않아서 발생한 문제를 해결했습니다.

* feat(be): implement prisma transaction when storing in db

*feat(be): implement bruno graphql api succeed request

*test(be): implement test for service code

* test(be): add api request assertion tests when succeed

* test(be): add graphql api bruno test
*feat(be): change contestproblem and workbookproblem database model to resolve unique key issue

* chore(be): delete clarification

* feat(fe): baseUrl variable for fetch (#1042)

* feat(fe): baseUrl variable for fetch

* chore(fe): typo

* feat: implement badge component for card

* feat: implement card component

* feat(fe): edit card design

* feat: seperate cards per purposes

* chore: install dayjs

* feat: set up point colors

* chore: add variant colors to badge

* feat: add util functions and types

* feat: implement main page

* feat: add time diff component

* chore: change time format

* fix: fix init state mismatch error

서버에서 pre-render한 값과 클라이언트에서 처음으로 렌더한 값이 다르면 에러가 발생합니다. init state를 concrete한 값으로 설정하여 에러를 해결합니다.

* feat(fe): implement card style

* feat(fe): implement card style

* chore(fe): fix badge size

* chore(fe): edit card component style setting

* chore: make badge smaller

* feat: apply border only to card-footer

* feat: add card header and more button

* chore: add problem id to problem-card title

* chore: remove margin on the top of title

* chore: set letter spacing as normal

* chore: contain cards inside grid

* chore: rearrange components

* fix: fix lock file

* feat: import carousel component from shadcn

* chore: use keyof typeof for badge prop types

* feat: implement carousel

* chore: remove carousel import from shadcn

* chore: reflect revised design

* chore: move main components

* fix: set href type as route

* feat: handle headers options

* fix(ci): load base url environment

* chore: fix merge conflicts

---------

Co-authored-by: Jaehyeon Kim <[email protected]>
Co-authored-by: Jaemin Choi <[email protected]>
Co-authored-by: LEE HAESUNG <[email protected]>
Co-authored-by: Gyunseo Lee <[email protected]>
Co-authored-by: Dayong Lee <[email protected]>
Co-authored-by: youznn <[email protected]>

* fix(fe): fixed light theme in sonner (#1125)

* fix(fe): remove theme in sooner

* fix: rollback to original source

* feat: implement use-pagination hook

* feat: use use-pagination hook from notice list page

* feat: use button instead of link for pagination items

* fix: always set take when fetching paginated data

* chore: scroll after pagination

* feat: scroll on render

* feat: add pagination to problem

* feat(fe): add badge component, font weight

* feat(fe): implement problem tag

* feat(fe): implement tag switch functionality

* chore(fe): fix switch component ui with primary color

* feat(fe): implement search with query string

* fix(fe): set init url with search parameters

* refactor: get init searchParmas from Page props

* fix(fe): fix build error

* fix(fe): add as Route to href

* fix(fe): fix layout

* feat(fe): delete pagination and separate SearchBar as component

* chore(fe): change router replace to push

* chore(fe): change submit function to handle empty input

* feat(fe): change tagSwitch to use query parameter

* chore(fe): add input value with query parameter

* chore(fe): add undefined value to init searchKeyword

* fix: reset notice page

* fix: remove as Route

* fix: typed error

* feat(fe): implement sorting with react-table

* feat(fe): implement sorting with query

* fix(fe): update pnpm lock file

* fix(fe): fix types in usePagination

---------

Co-authored-by: Sori Lim <[email protected]>
Co-authored-by: Jiho Park <[email protected]>
Co-authored-by: Dayong Lee <[email protected]>
Co-authored-by: Gyunseo Lee <[email protected]>
Co-authored-by: Jaemin Choi <[email protected]>
Co-authored-by: Jaehyeon Kim <[email protected]>
Co-authored-by: LEE HAESUNG <[email protected]>
Co-authored-by: Kohminchae <[email protected]>
SH9480P pushed a commit that referenced this pull request Jan 24, 2024
* feat: set up page

* feat(fe): scaffolding colums and rows in table

* feat(fe): set fixed width, add responsiveness, include hover effect

* feat(fe): implement sorting

* chore(fe): undo sorting button

* chore(fe): change switch color to primary color

* feat(fe): implement tag switch, keyword search bar and the number of problems

* chore(fe): add font weight 700, 800

* fix(fe): cover style (#1111)

* feat(fe): change toaster to sonner (#1112)

* feat(fe): fixed notice (#1116)

* feat(fe): fixed notice

* fix: lockfile version

* feat(fe): add writer section at notice table (#1119)

* fix: auto layout to fixed layout

* feat(fe): notice table add writer column

---------

Co-authored-by: dayongkr <[email protected]>

* feat(be): implement problem title search api (#1122)

* fix(be): fix prisma schema to enable full-text search using preview feature

* feat(be): implement problem title search using full-text search

* fix(be): change from full-text search to exact match using prisma contains option

* docs(be): update bruno docs

* fix(be): add todo and fixme comment

* fix(cd): create iam role for ecr push (#1124)

* feat(fe): implement main page (#1075)

* feat(fe): add card component from shadcn

* docs(be): add client contest module api docs (#954)

Co-authored-by: Jaemin Choi <[email protected]>

* feat(be): rename clarification module to announcement (#794)

* feat(be): add annoucecment model to scheme and module to client

* feat(be): implement get announcement methods

* feat(be): implement group controllers

* chore(be): append missing controllers and tc ex

* feat(be): devide into problem and contest announcement

* chore(be): fakerjs installation

* feat(be): test codes - announcements

* fix(be): seeding announcements

* fix(be): prisma query

* fix(be): some to every

* feat(be): implement storing Contest/WorkbookProblem id in order field with graphql (#819)

* feat(be): modify WorkbookProblem and ContestProblem field

각각 DB에서의 id 필드를 order 필드로 수정했습니다.

* feat(be): implement getWorkbookProblems and updateWorkbookProblemsOrder

test(be): add service test codes for getWorkbookProblems and updateWorkbookProblemsOrder

* fix(be): fix return type of workbookproblem resolver

* feat(be): implement storing ContestProblem id in order field

contest-problem resource를 만들어, ContestProblem의 id 값을 order로 설정하여 변경하는 로직을 구현했습니다.

feat(be): implement storing WorkbookProblem id in order field

workbook-problem resource를 만들어, WorkbookProblem의 id 값을 order로 설정하여 변경하는 로직을 구현했습니다.

* chore(be): remove unused import module in admin module
- admin.module.ts에서 안 쓰는 module을 정리했습니다.

* refactor(be): migrate contest/workbook-problem res code to problem res

contest-problem과 workbook-problem res에 있는 코드를 problem res로 migration 했습니다.

* feat(be): implement checking if contest/workbook is in groupId
contest와 workbook이 groupId에 속하는지 확인하는 로직을 추가했습니다.

* test(be): add test code for probem service

contest-problem res와 workbook-problem res에 있던 test code를 problem res로 옮겼습니다.

* chore(be): delete unused res
contest-problem res와 workbook-problem res 삭제

* chore(be): change clarification service code to resolve type error
바뀐 contestProblem db schema의 type error를 resolve하기 위해 코드를 수정했습니다.

*chore(be): change contest service code to resolve type error
바뀐 contestProblem db schema의 type error를 resolve하기 위해 코드를 수정했습니다.

* chore(be): add some comment on the service code

* feat(be): change workbookProblem order update logic

feat(be): chage contestProblem order update logic

* feat(be): add prisma transaction when updating workbook/contestProblems order

test(be): add test for updating workbook/contestProblems order

* feat(be): updateContestProblemsOrder 로직 수정
order 필드는 정수 1부터 시작하도록 수정

* test(be): fix problem service test code
매번 테스트를 하기 전에 stub을 초기화 해주지 않아서 발생한 문제를 해결했습니다.

* feat(be): implement prisma transaction when storing in db

*feat(be): implement bruno graphql api succeed request

*test(be): implement test for service code

* test(be): add api request assertion tests when succeed

* test(be): add graphql api bruno test
*feat(be): change contestproblem and workbookproblem database model to resolve unique key issue

* chore(be): delete clarification

* feat(fe): baseUrl variable for fetch (#1042)

* feat(fe): baseUrl variable for fetch

* chore(fe): typo

* feat: implement badge component for card

* feat: implement card component

* feat(fe): edit card design

* feat: seperate cards per purposes

* chore: install dayjs

* feat: set up point colors

* chore: add variant colors to badge

* feat: add util functions and types

* feat: implement main page

* feat: add time diff component

* chore: change time format

* fix: fix init state mismatch error

서버에서 pre-render한 값과 클라이언트에서 처음으로 렌더한 값이 다르면 에러가 발생합니다. init state를 concrete한 값으로 설정하여 에러를 해결합니다.

* feat(fe): implement card style

* feat(fe): implement card style

* chore(fe): fix badge size

* chore(fe): edit card component style setting

* chore: make badge smaller

* feat: apply border only to card-footer

* feat: add card header and more button

* chore: add problem id to problem-card title

* chore: remove margin on the top of title

* chore: set letter spacing as normal

* chore: contain cards inside grid

* chore: rearrange components

* fix: fix lock file

* feat: import carousel component from shadcn

* chore: use keyof typeof for badge prop types

* feat: implement carousel

* chore: remove carousel import from shadcn

* chore: reflect revised design

* chore: move main components

* fix: set href type as route

* feat: handle headers options

* fix(ci): load base url environment

* chore: fix merge conflicts

---------

Co-authored-by: Jaehyeon Kim <[email protected]>
Co-authored-by: Jaemin Choi <[email protected]>
Co-authored-by: LEE HAESUNG <[email protected]>
Co-authored-by: Gyunseo Lee <[email protected]>
Co-authored-by: Dayong Lee <[email protected]>
Co-authored-by: youznn <[email protected]>

* fix(fe): fixed light theme in sonner (#1125)

* fix(fe): remove theme in sooner

* fix: rollback to original source

* feat: implement use-pagination hook

* feat: use use-pagination hook from notice list page

* feat: use button instead of link for pagination items

* fix: always set take when fetching paginated data

* chore: scroll after pagination

* feat: scroll on render

* feat: add pagination to problem

* feat(fe): add badge component, font weight

* feat(fe): implement problem tag

* feat(fe): implement tag switch functionality

* chore(fe): fix switch component ui with primary color

* feat(fe): implement search with query string

* fix(fe): set init url with search parameters

* refactor: get init searchParmas from Page props

* fix(fe): fix build error

* fix(fe): add as Route to href

* fix(fe): fix layout

* feat(fe): delete pagination and separate SearchBar as component

* chore(fe): change router replace to push

* chore(fe): change submit function to handle empty input

* feat(fe): change tagSwitch to use query parameter

* chore(fe): add input value with query parameter

* chore(fe): add undefined value to init searchKeyword

* fix: reset notice page

* fix: remove as Route

* fix: typed error

* feat(fe): implement sorting with react-table

* feat(fe): implement sorting with query

* fix(fe): update pnpm lock file

* fix(fe): fix types in usePagination

---------

Co-authored-by: Sori Lim <[email protected]>
Co-authored-by: Jiho Park <[email protected]>
Co-authored-by: Dayong Lee <[email protected]>
Co-authored-by: Gyunseo Lee <[email protected]>
Co-authored-by: Jaemin Choi <[email protected]>
Co-authored-by: Jaehyeon Kim <[email protected]>
Co-authored-by: LEE HAESUNG <[email protected]>
Co-authored-by: Kohminchae <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done ✔️
Development

Successfully merging this pull request may close these issues.

change cover style
2 participants