Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fe): open graph and manifest #1095

Merged
merged 5 commits into from
Dec 29, 2023
Merged

feat(fe): open graph and manifest #1095

merged 5 commits into from
Dec 29, 2023

Conversation

dayongkr
Copy link
Contributor

@dayongkr dayongkr commented Dec 29, 2023

Description

<meta name="theme-color" content="#3581FA"/>
<title>Codedang 코드당</title>
<meta name="description" content="Codedang, Online Judge for SKKU"/>
<link rel="manifest" href="/manifest.webmanifest"/>
<meta property="og:title" content="Codedang 코드당"/>
<meta property="og:description" content="Codedang, Online Judge for SKKU"/>
<meta property="og:image:type" content="image/png"/>
<meta property="og:image:width" content="1200"/>
<meta property="og:image:height" content="630"/>
<meta property="og:image" content="http://localhost:5525/opengraph-image.png?cb0a20e5f89e7261"/>
<meta name="twitter:card" content="summary_large_image"/>
<meta name="twitter:title" content="Codedang 코드당"/>
<meta name="twitter:description" content="Codedang, Online Judge for SKKU"/>
<meta name="twitter:image:type" content="image/png"/>
<meta name="twitter:image:width" content="1200"/>
<meta name="twitter:image:height" content="630"/>
<meta name="twitter:image" content="http://localhost:5525/opengraph-image.png?cb0a20e5f89e7261"/>
<link rel="icon" href="/favicon.ico" type="image/x-icon" sizes="16x16"/>
<link rel="icon" href="/icon.png?f7b253c1e67da8ee" type="image/png" sizes="32x32"/>
<link rel="apple-touch-icon" href="/apple-icon.png?26c316701e174975" type="image/png" sizes="180x180"/>
  • Next.js의 File based 기능을 이용
    • apple touch icon, opengraph image, icon(32x32), manifest
    • Screenshot 2023-12-29 at 5 56 49 PM
    • app 폴더에 파일이 너무 많아지는 단점이 있음 -> public으로 다 몰아 넣고 root layout의 metadata 객체를 수정하는 방법도 있음

close #1094


Before submitting the PR, please make sure you do the following

Copy link

vercel bot commented Dec 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
codedang ✅ Ready (Inspect) Visit Preview Dec 29, 2023 8:54am

Copy link
Member

@dotoleeoak dotoleeoak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다
저는 app 폴더에 파일 개수 늘어나는 건 신경 안 써도 괜찮을 거 같네요

@dayongkr dayongkr merged commit af03253 into main Dec 29, 2023
26 checks passed
@dayongkr dayongkr deleted the 1094-opengraph branch December 29, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open Graph 태그 추가
2 participants