fix(be): make admin to get all contest submissions (#1652)

- 어드민이 모든 제출을 볼 수 있도록 합니다. - 전 커밋의 계속해서 제출이 보이지 않던 문제를 해결합니다.
skkuding · Apr 15, 2024 · 07af7ea · 07af7ea
1 parent 3179115
commit 07af7ea
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 15 deletions.
diff --git a/apps/backend/apps/client/src/submission/submission.controller.ts b/apps/backend/apps/client/src/submission/submission.controller.ts
@@ -172,7 +172,6 @@ export class ContestSubmissionController {
         problemId,
         contestId,
         userId: req.user.id,
-        isAdmin: req.user.isAdmin(),
         groupId
       })
     } catch (error) {

diff --git a/apps/backend/apps/client/src/submission/submission.service.spec.ts b/apps/backend/apps/client/src/submission/submission.service.spec.ts
@@ -422,8 +422,7 @@ describe('SubmissionService', () => {
         await service.getContestSubmissions({
           problemId: problems[0].id,
           contestId: 1,
-          userId: submissions[0].userId,
-          isAdmin: false
+          userId: submissions[0].userId
         })
       )
     })
@@ -437,8 +436,7 @@ describe('SubmissionService', () => {
         service.getContestSubmissions({
           problemId: problems[0].id,
           contestId: 1,
-          userId: submissions[0].userId,
-          isAdmin: false
+          userId: submissions[0].userId
         })
       ).to.be.rejectedWith(NotFoundException)
     })
@@ -453,8 +451,7 @@ describe('SubmissionService', () => {
         service.getContestSubmissions({
           problemId: problems[0].id,
           contestId: 1,
-          userId: submissions[0].userId,
-          isAdmin: false
+          userId: submissions[0].userId
         })
       ).to.be.rejectedWith(NotFoundException)
     })

diff --git a/apps/backend/apps/client/src/submission/submission.service.ts b/apps/backend/apps/client/src/submission/submission.service.ts
@@ -628,30 +628,38 @@ export class SubmissionService implements OnModuleInit {
     problemId,
     contestId,
     userId,
-    isAdmin,
     groupId = OPEN_SPACE_ID,
     cursor = null,
     take = 10
   }: {
     problemId: number
     contestId: number
     userId: number
-    isAdmin: boolean
     groupId?: number
     cursor?: number | null
     take?: number
   }): Promise<Partial<Submission>[]> {
     const paginator = this.prisma.getPaginator(cursor)
 
-    await this.prisma.contestRecord.findUniqueOrThrow({
+    const isAdmin = await this.prisma.user.findFirst({
       where: {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
-        contestId_userId: {
-          contestId,
-          userId
-        }
+        id: userId,
+        role: 'Admin'
       }
     })
+
+    if (!isAdmin) {
+      await this.prisma.contestRecord.findUniqueOrThrow({
+        where: {
+          // eslint-disable-next-line @typescript-eslint/naming-convention
+          contestId_userId: {
+            contestId,
+            userId
+          }
+        }
+      })
+    }
+
     await this.prisma.contestProblem.findFirstOrThrow({
       where: {
         problem: {