Fix panic when turning off use_cache
#22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, could you please push an empty commit to trigger the CI ? |
The main problem with the old code was that all of the cache RefCells
were held for too long because of the huge scope of the `fuzzy`
function. The problem was already solved by just wrapping some of the
code with an extra scope `{` + `}`. However I chose to refactor a bit
and split the old function into 3 new ones:
- `simple_match` - was already there
- `sophisticated_match` - basically the else case of `simple_match`
- `fuzzy_inner` - a function just for the control flow of the other
function. This also handles the cache invalidation
This should supersede the pull request skim-rs#20
RobWalt
force-pushed
the
fix/panic-no-cache
branch
from
21d8d30 to
a399f39
Compare
This reverts commit 681507e.
|
@LoricAndre Doesn't really seem to work |
|
@RobWalt could you please fix the tests before we can review this ? |
|
@LoricAndre Sure, should I open a separate PR for this as this has nothing to do with my changes? (The CI also fails on main for the same reason) I think it's mainly because of the old version of |
|
Then wait for a bit, we have some work on skim itself then we'll work on updating this repo and making sure everything looks alright, then you can rebase and we'll merge this |
|
No worries! Thanks for taking the time to review the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main problem with the old code was that all of the cache RefCells
were held for too long because of the huge scope of the
fuzzyfunction. The problem was already solved by just wrapping some of the
code with an extra scope
{+}. However I chose to refactor a bitand split the old function into 3 new ones:
simple_match- was already theresophisticated_match- basically the else case ofsimple_matchfuzzy_inner- a function just for the control flow of the otherfunction. This also handles the cache invalidation
This should supersede the pull request #20