Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Text fragments missing last fragment #174

Closed
wants to merge 1 commit into from
Closed

fix Text fragments missing last fragment #174

wants to merge 1 commit into from

Conversation

robintindale
Copy link
Contributor

fix for #144

@bohemian-coding-danger
Copy link
Collaborator

Warnings
⚠️

This pull request may need a CHANGELOG entry.
⚠️

Source/dom/components/Text.js changed, but not its tests. That's OK as long as you're refactoring.
⚠️

Source/dom/components/Text.js changed, but not its doc. That's OK as long as you're refactoring.

Generated by 🚫 dangerJS

@mathieudutour
Copy link
Contributor

oh I missed that sorry.

Is the fix really that simple? There is a really nice issue: matt-curtis/Sketch-Highlighter#3 that describe a bunch cases. I'll try to write some unit tests for each of them

@robintindale
Copy link
Contributor Author

it seems to fix the issue as it was reported in #144, obviously can't speak for all those test cases :)

@mathieudutour mathieudutour mentioned this pull request Oct 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robintindale @bohemian-coding-danger @mathieudutour