Made ProgressRing show label on demand

[phamduylong]

Linked Issue

Closes #2992

Description

Made label show only on demand

TODO: update site examples and generate changesets

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

• This PR targets the dev branch (NEVER master)
• Documentation reflects all relevant changes
• Branch is prefixed with: docs/, feat/, chore/, bugfix/
• Ensure Svelte and Typescript linting is current - run pnpm ci:check
• Ensure Prettier linting is current - run pnpm format
• All test cases are passing - run pnpm test
• Includes a changeset (if relevant; see above)

[changeset-bot]

🦋 Changeset detected

Latest commit: b17647b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@skeletonlabs/skeleton-svelte	Patch
@skeletonlabs/skeleton-react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

@phamduylong is attempting to deploy a commit to the Skeleton Labs Team on Vercel.

A member of the Team first needs to authorize it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
skeleton-docs	❌ Failed (Inspect)		Nov 23, 2024 8:43am

[endigo9740]

Looks great Long. If you could make these couple minor changes and supply the documentation updates requested, then this should be good to go.

[phamduylong]

Looks great Long. If you could make these couple minor changes and supply the documentation updates requested, then this should be good to go.

Yeah it's not finished yet, there's no draft flag on PR in GitHub it seems. I'll probably get it done soon enough when I figure out how to update site examples and refactor the stuff you pointed out. Thanks for the review.

[endigo9740]

There's an option when creating PRs to mark it as a draft, otherwise they have a super tiny option on the sidebar near where you assign reviewers. Not sure why it's not more obvious, but it is there! :)

[phamduylong]

@endigo9740 probably could be permission issues that caused this :D I don't have the option. Could you un-draft this and give this another review?

Edit: NVM I can un-draft it. This is ready nonetheless