Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/radio group region label prop #1836

Merged

Conversation

SebasF1349
Copy link
Member

Linked Issue

Closes #1786

Description

Added regionLabel prop to the Radio Group

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

🦋 Changeset detected

Latest commit: 058cd47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@skeletonlabs/skeleton Minor
skeleton.dev Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Aug 8, 2023 7:58pm

@Mahmoud-zino
Copy link
Contributor

suggestion: we might want to add regionItem and regionInput in the same PR to cover all possible regions.

@endigo9740
Copy link
Contributor

@SebasF1349 FYI you had the right idea, but the fix isn't quite right.

This was actually a regression introduced when we added the label > div structure. All the "base" styles were being applied to the div, even though base styles should ALWAYS be applied to the outter-most parent element. The label in this case.

You could see cBase set already setting flex-auto previously. But once that was removed from label, this brought about the regression.

I've committed a small change that resolves all this, and kept your regionLabel prop, as I'm sure it'll be useful! Let me know if you approve and I'll aim to merge this right away.

@SebasF1349
Copy link
Member Author

Now the docs comment makes sense, it was correct before. Thanks for the explanation. Didn't notice the flex-auto, should have checked the other classes. Let's merge it!

@endigo9740 endigo9740 merged commit 1c35e15 into skeletonlabs:dev Aug 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Incorrect" suggestion in Radio Groups
3 participants