-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/radio group region label prop #1836
Feat/radio group region label prop #1836
Conversation
🦋 Changeset detectedLatest commit: 058cd47 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
suggestion: we might want to add |
@SebasF1349 FYI you had the right idea, but the fix isn't quite right. This was actually a regression introduced when we added the You could see I've committed a small change that resolves all this, and kept your |
Now the docs comment makes sense, it was correct before. Thanks for the explanation. Didn't notice the |
Linked Issue
Closes #1786
Description
Added
regionLabel
prop to the Radio GroupChangsets
Instructions: Changesets automate our changelog. If you modify files in
/packages/skeleton
, runpnpm changeset
in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminor
while chores and bugfixes should bepatch
. Please prefix the changeset message withfeat:
,bugfix:
orchore:
.Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm check
pnpm format
pnpm test