feat(lex,parse): Add stub try/catch implementation #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RBI 9.4 adds support for error handling via the `try`/`catch` model [1]. Interestingly, `try`, `catch`, and `endtry` are all valid identifiers! That makes parsing a little bit tougher, but it's not unprecedented in this language. Detect `try`/`catch`/throw`/`end try` during lexing and emit the proper lexemes. [1] https://developer.roku.com/docs/references/brightscript/language/error-handling.html see #554
sjbarag
added
enhancement
sjbarag
force-pushed
the
stub-try-catch
branch
from
22c9744 to
fe9077e
Compare
Throwing exceptions and catching them aren't yet supported in `brs`, so executing only the `try` block seems to be a reasonable "bare minimum" approach to try/catch support. Handle `try`, `catch`, and `end try` lexemes in the parser, emitting TryCatch statements for the interpreter to execute naïvely. see #554
sjbarag
force-pushed
the
stub-try-catch
branch
from
fe9077e to
a5487ed
Compare
sjbarag
requested review from
lkipke,
alimnios72,
kirkyoder and
strattonbrazil
alimnios72
approved these changes
Jan 21, 2021
| @@ -94,6 +98,8 @@ export const KeyWords: { [key: string]: L } = { | |||
| stop: L.Stop, | |||
| sub: L.Sub, | |||
| to: L.To, | |||
| try: L.Try, | |||
There was a problem hiding this comment.
Noob question: why are try and endtry keywords but not reserved words while throw is both?
This was referenced Nov 29, 2023
|
Try..Catch and Throw implementation was finished in the Roku Community fork: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing
try/catch/throwtakes a good bit of work in the interpreter, so I'm splitting that into two pull requests. This one includes parsingtry/catch/end try(withoutthrow), and always executes only thetryblock to maintain backwards compatibility. It's a weird partial state, but the alternative is a massive pull request that can't be reasonably reviewed or understood.see #554