Use sealed traits instead of unsafe markers on traits #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9names
changed the title
9names
force-pushed
the
use-sealed-traits
branch
2 times, most recently
from
4b1d00f
to
27b5ec6
Compare
9names
force-pushed
the
use-sealed-traits
branch
from
27b5ec6
to
b7baafe
Compare
9names
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the sealed trait pattern from
https://rust-lang.github.io/api-guidelines/future-proofing.html
i2c and spi traits are well constrained already, haven't worked out the correct syntax for serial.
it's probably overkill, since you can't construct a uart without uart pins, and they are already constrained.
[edit]
Decided not to seal uart trait due to above