Minor updates to the paper #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trulsf
reviewed
Oct 29, 2024
|
I think your paragraph is an improvement. Minor adjustments: plural both for index sets and equations? s/must not/need not/. |
hellemo
approved these changes
Oct 29, 2024
Co-authored-by: Truls Flatberg <[email protected]> Co-authored-by: hellemo <[email protected]>
trulsf
added a commit
that referenced
this pull request
Nov 1, 2024
* Minor updates to the paper * Apply suggestions from code review * Included changed paragraph --------- Co-authored-by: Truls Flatberg <[email protected]> Co-authored-by: hellemo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally speaking, I think it looks good.
I went mostly through the grammar and split sentences to improve the readability. However, I did not come up with a nice solution for the sentence starting in l. 38. I do not really like the way we have it written right now as it is a bit convoluted and really long. That makes it hard to understand.
One suggestion is
TimeStruct simplifies the writing of key equations in optimization problems through separation of the indexing sets and the equation. Consequently, equations unaffected by the the chosen time structure, e.g., simple deterministic operational or stochastic programming models, must not be adjusted when switching between different time structures. Hence, it simplifies both model development and subsequent switching between different time structures.
What are your thoughts? Is that paragraph still capturing the essence of he previous paragraph?