Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tf/joss example #39

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Tf/joss example #39

merged 3 commits into from
Oct 28, 2024

Conversation

trulsf
Copy link
Member

@trulsf trulsf commented Oct 27, 2024

No description provided.

@trulsf trulsf requested a review from hellemo October 27, 2024 16:02
Copy link
Member

@hellemo hellemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. I tried to address the remaining TODOS by changing to pdfs and adding some references in the introduction.

@trulsf trulsf merged commit 05aa360 into joss_submission Oct 28, 2024
6 checks passed
@trulsf trulsf deleted the tf/joss_example branch October 28, 2024 08:13
trulsf added a commit that referenced this pull request Nov 1, 2024
* Updated figures plus pdf versions

* Code example, minor changes and some extra links

* Change to pdf, add links in introduction.

---------

Co-authored-by: Lars Hellemo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants