Modify routing event handling to do nothing if navigation is cancelled #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joeldenning This is a backport of #190. Looks good to merge. |
joeldenning
approved these changes
Oct 2, 2023
|
published in [email protected]. It's under the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the same problem found in #190 but with the previous major version. Currently, this fix is only present in the new 2.x version which depends on the latest beta for single-spa (currently 6.0.0-beta3). Updating to this version is technically not a problem but this can a problem for project which don't use betas.
I understand that the beta is deemed stable but the "beta" state in the version name and the fact that this beta is older then the newest 5.x version can scare a lot of people.