Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Handle Routing Event - Don't Unmount If Navigation is Cancelled #190

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Fix - Handle Routing Event - Don't Unmount If Navigation is Cancelled #190

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec7341e
added fix for handle routing event when navigation is cancelled
Jun 13, 2023
5ce19c8
Update package.json
joeldenning Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/browser/constructLayoutEngine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,15 +204,18 @@ export function constructLayoutEngine({
});
}

function handleRoutingEvent({ detail: { newUrl } }) {
getAppsToUnmount(newUrl).forEach((name) => {
const applicationElement = document.getElementById(
applicationElementId(name)
);
if (applicationElement && applicationElement.isConnected) {
applicationElement.parentNode.removeChild(applicationElement);
}
});
function handleRoutingEvent({ detail: { navigationIsCanceled, newUrl } }) {
// only unmount if navigation is not cancelled
if (!navigationIsCanceled) {
getAppsToUnmount(newUrl).forEach((name) => {
const applicationElement = document.getElementById(
applicationElementId(name)
);
if (applicationElement && applicationElement.isConnected) {
applicationElement.parentNode.removeChild(applicationElement);
}
});
}
}

/**
Expand Down