Fix - Handle Routing Event - Don't Unmount If Navigation is Cancelled (…

…#190) * added fix for handle routing event when navigation is cancelled * Update package.json --------- Co-authored-by: Brandon Ferrari <[email protected]> Co-authored-by: Joel Denning <[email protected]>
single-spa · Jun 15, 2023 · eef6b1b · eef6b1b
1 parent 325f6ef
commit eef6b1b
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/src/browser/constructLayoutEngine.js b/src/browser/constructLayoutEngine.js
@@ -204,15 +204,18 @@ export function constructLayoutEngine({
     });
   }
 
-  function handleRoutingEvent({ detail: { newUrl } }) {
-    getAppsToUnmount(newUrl).forEach((name) => {
-      const applicationElement = document.getElementById(
-        applicationElementId(name)
-      );
-      if (applicationElement && applicationElement.isConnected) {
-        applicationElement.parentNode.removeChild(applicationElement);
-      }
-    });
+  function handleRoutingEvent({ detail: { navigationIsCanceled, newUrl } }) {
+    // only unmount if navigation is not cancelled
+    if (!navigationIsCanceled) {
+      getAppsToUnmount(newUrl).forEach((name) => {
+        const applicationElement = document.getElementById(
+          applicationElementId(name)
+        );
+        if (applicationElement && applicationElement.isConnected) {
+          applicationElement.parentNode.removeChild(applicationElement);
+        }
+      });
+    }
   }
 
   /**