Add Jest tests and publish automation with changesets #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robmosca
commented
Sep 11, 2023
| @@ -31,7 +31,7 @@ injectorImportMaps.forEach((scriptEl) => { | |||
| return r.json(); | |||
| } else { | |||
| throw Error( | |||
| `${errPrefix} import map at url '${scriptEl.src}' must respond with a success HTTP status, but responded with HTTP ${r.status} ${r.statusText}`, | |||
| `${errPrefix} Import map at url '${scriptEl.src}' must respond with a success HTTP status, but responded with HTTP ${r.status} ${r.statusText}`, | |||
There was a problem hiding this comment.
To harmonize the casing to the other error messages
robmosca
commented
Sep 11, 2023
| @@ -69,8 +69,12 @@ const requiresMicroTick = importMapJsons.some( | |||
| (json) => json instanceof Promise, | |||
| ); | |||
|
|
|||
| const globalWindow = window as typeof window & { | |||
There was a problem hiding this comment.
Needed by Typescript (otherwise throws a type error)
robmosca
commented
Sep 11, 2023
| @@ -112,3 +116,5 @@ function injectImportMap(importMaps: ImportMap[]): void { | |||
| finalImportMapScriptEl.textContent = JSON.stringify(finalImportMap); | |||
| document.head.appendChild(finalImportMapScriptEl); | |||
| } | |||
|
|
|||
| export {}; | |||
There was a problem hiding this comment.
Needed in order to be able to import the module in Jest. Otherwise, it complains the file is not a module.
|
Closed in favour of #10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues:
In particular:
For this to work it is necessary that:
See single-spa/single-spa-react#178 for a description of how this works.
The automated pipeline includes:
Current coverage:
