Skip to content

Commit

Permalink
Remove unneeded react-dom (#430)
Browse files Browse the repository at this point in the history
  • Loading branch information
joeldenning authored Dec 18, 2024
1 parent f3fcb82 commit 1cdc37e
Show file tree
Hide file tree
Showing 3 changed files with 224 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/cool-pillows-live.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"generator-single-spa": patch
---

Remove unneeded ReactDOM
2 changes: 0 additions & 2 deletions packages/generator-single-spa/src/react/templates/src/main.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
import React from "react";
import ReactDOM from "react-dom";
import ReactDOMClient from "react-dom/client";
import singleSpaReact from "single-spa-react";
import Root from "./root.component";

const lifecycles = singleSpaReact({
React,
ReactDOM,
ReactDOMClient,
rootComponent: Root,
errorBoundary(err, info, props) {
Expand Down
Loading

0 comments on commit 1cdc37e

Please sign in to comment.