Skip to content

Commit

Permalink
Drop python-snappy from dependencies. (rapidsai#15161)
Browse files Browse the repository at this point in the history
Previously `python-snappy` was a test dependency. It does not appear that we rely on this directly, as there are no instances of `import snappy`. Recently, pandas also dropped this dependency: pandas-dev/pandas#54633

More generally, we can refactor the dependency list to use `pandas[all]` now that we require pandas 2.

Authors:
   - Bradley Dice (https://github.com/bdice)

Approvers:
   - Kyle Edwards (https://github.com/KyleFromNVIDIA)
   - Vyas Ramasubramani (https://github.com/vyasr)
   - GALI PREM SAGAR (https://github.com/galipremsagar)
   - Ray Douglass (https://github.com/raydouglass)
  • Loading branch information
bdice authored Feb 28, 2024
1 parent 990ef0f commit 8526e6d
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 89 deletions.
1 change: 0 additions & 1 deletion conda/environments/all_cuda-118_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ dependencies:
- pytest-xdist
- pytest<8
- python-confluent-kafka>=1.9.0,<1.10.0a0
- python-snappy>=0.6.0
- python>=3.9,<3.11
- pytorch<1.12.0
- rapids-dask-dependency==24.4.*
Expand Down
1 change: 0 additions & 1 deletion conda/environments/all_cuda-122_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ dependencies:
- pytest-xdist
- pytest<8
- python-confluent-kafka>=1.9.0,<1.10.0a0
- python-snappy>=0.6.0
- python>=3.9,<3.11
- pytorch<1.12.0
- rapids-dask-dependency==24.4.*
Expand Down
46 changes: 2 additions & 44 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,6 @@ dependencies:
- hypothesis
- pytest-benchmark
- pytest-cases>=3.8.2
- python-snappy>=0.6.0
- scipy
- output_types: conda
packages:
Expand Down Expand Up @@ -712,49 +711,8 @@ dependencies:
packages:
# dependencies to run pandas tests
# https://github.com/pandas-dev/pandas/blob/main/environment.yml
# TODO: When pandas 2.0 is the minimum version, can just specify pandas[all]
- beautifulsoup4
- blosc
- brotlipy
- boto3
- botocore>=1.24.21
- bottleneck
- fastparquet
- flask
- fsspec
- html5lib
- hypothesis
- gcsfs
- ipython
- jinja2
- lxml
- matplotlib
- moto
- numba
- numexpr
- openpyxl
- odfpy
- py
- psycopg2-binary
- pyarrow
- pymysql
- pyreadstat
- pytest-asyncio
- pytest-reportlog
- python-snappy
- pytest-timeout
- pyxlsb
- s3fs
- scipy
- sqlalchemy
- tables
- pandas-gbq
- tabulate
- xarray
- xlrd
- xlsxwriter
- xlwt
- zstandard
# pandas[all] includes all of the required dependencies
- pandas[all]
test_python_cudf_pandas:
common:
- output_types: pyproject
Expand Down
44 changes: 1 addition & 43 deletions python/cudf/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -62,55 +62,13 @@ test = [
"pytest-cov",
"pytest-xdist",
"pytest<8",
"python-snappy>=0.6.0",
"scipy",
"tokenizers==0.13.1",
"transformers==4.24.0",
"tzdata",
] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.
pandas-tests = [
"beautifulsoup4",
"blosc",
"boto3",
"botocore>=1.24.21",
"bottleneck",
"brotlipy",
"fastparquet",
"flask",
"fsspec",
"gcsfs",
"html5lib",
"hypothesis",
"ipython",
"jinja2",
"lxml",
"matplotlib",
"moto",
"numba",
"numexpr",
"odfpy",
"openpyxl",
"pandas-gbq",
"psycopg2-binary",
"py",
"pyarrow",
"pymysql",
"pyreadstat",
"pytest-asyncio",
"pytest-reportlog",
"pytest-timeout",
"python-snappy",
"pyxlsb",
"s3fs",
"scipy",
"sqlalchemy",
"tables",
"tabulate",
"xarray",
"xlrd",
"xlsxwriter",
"xlwt",
"zstandard",
"pandas[all]",
] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.
cudf-pandas-tests = [
"ipython",
Expand Down

0 comments on commit 8526e6d

Please sign in to comment.