Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should parse json string flag #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SamProtas
Copy link

Description of change

As discussed #92

This allows users to opt-out of the metafield.value "parse json_string" behavior. I needed this because my desired target (singer-target-postgres) did not support a single field being int/string/object.

The Shopify API returns a string field, this feature lets the user keep it a string.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

I've been running this locally against our live Shopify store. I've observed it correctly working (keeping metafield.value as a string type when metafield.value_type is json_string). I've observed this allowing this shopify value to end up in my postgres db via singer-target-postgres, solving my problem.

Risks

This adds a small amount of surface area to the code, but this doesn't appear to interact with anything else in the program.

Rollback steps

  • revert this branch

@cmerrick
Copy link

cmerrick commented Apr 1, 2021

Hi @SamProtas, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link

cmerrick commented Apr 2, 2021

You did it @SamProtas!

Thank you for signing the Singer Contribution License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants