Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with empty types in orders #83

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sphinks
Copy link

@sphinks sphinks commented Feb 18, 2021

Description of change

Fix will partly eliminate the issue with error of validating schema. It is referenced here: #78 and here transferwise/pipelinewise-target-snowflake#140 I got the issue with orders schema (to make easy to google the resolution):

if 'string' in schema['properties'][key]['type'] and \
KeyError: 'type'

QA steps

  • import data from shopify is working as expected

Risks

Rollback steps

  • revert this branch

P.S. It looks like the project is abadoned, so I'm doing the PR without hope to get it merged into master. Just to get an idea how to fix the issue.

@cmerrick
Copy link

Hi @sphinks, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@sphinks
Copy link
Author

sphinks commented Feb 18, 2021

@cmerrick if it is possible just leave some comment to get an idea if you are still looking into PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants