Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove whitelist of receipt keys for canonicalize #53

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

luandy64
Copy link
Contributor

@luandy64 luandy64 commented Mar 4, 2020

Description of change

This PR changes the tap from canonicalizing 3 fields on the receipt object of transactions to canonicalizing all fields on the the receipt object.

Changes:

  • Remove whitelist of receipt keys
  • update tests

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
    • Ran the unittests

Risks

  • Low-Moderate:
    • We know of 3 fields that can come back as lower+uppercased, but we and Shopify don't know of all of the possibilities
      • The risk is in the fact that we there could be a receipt field that is and has always been capitalized. This PR would cause that column to split because we would start to canonicalize it

Rollback steps

  • revert this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants