WIP: tentative increment change, in reference to issue #39 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zboldyga, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
|
You did it @zboldyga! Thank you for signing the Singer Contribution License Agreement. |
zboldyga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
(write a short description here or paste a link to JIRA)
QA steps
Risks
Rollback steps
This is a tentative fix to a potential problem outlined in issue #39, to help clarify expected behavior as per Microsoft's SQL Server documentation: https://docs.microsoft.com/en-us/sql/relational-databases/track-changes/work-with-change-tracking-sql-server?view=sql-server-2017 .
In essence, decrementing the CHANGE_TRACKING_CURRENT_VERSION() by one is not recommended by Microsoft. This is leading to lots of duplicate row copying.
...
I have not tested the change yet, and in order to fully fix this issue, the test cases might need to be adjusted. I'm happy to finalize the implementation to speed-up this fix, if we find that it is correct.