chore: fix accessibility permission check logic 🔧

[kentbetita]

Description

This pull request addresses an issue where the package was incorrectly prompting for accessibility permissions even when the disableAccessibilityPermission option was set to false.

Changes

• Updated the logic in main.swift to ensure that the accessibility permission prompt is conditionally executed based on the disableAccessibilityPermission flag.
• Wrapped the AXIsProcessTrustedWithOptions call within an explicit if block to prevent unintended permission prompts.

Problem

The original code used a comma-separated list of conditions in an if statement, which in Swift, functions as a logical AND operator. This meant that both conditions had to be evaluated, and as long as the first condition (!disableAccessibilityPermission) was true (i.e., disableAccessibilityPermission was false), the second condition (!AXIsProcessTrustedWithOptions(["AXTrustedCheckOptionPrompt": true] as CFDictionary)) would also be evaluated.

This led to a situation where, even when disableAccessibilityPermission was set to false, the code would still trigger the accessibility permission check because the second condition was always checked, thus resulting in an unintended prompt for accessibility permission.

Solution

The solution involved restructuring the conditional statement to ensure that the AXIsProcessTrustedWithOptions check is only performed when disableAccessibilityPermission is explicitly set to false. Now, the second condition is entirely dependent on the first condition being true. This change respects the user's preference for the disableAccessibilityPermission flag and prevents the accessibility permission prompt from appearing unless it is necessary.

Testing

• Made sure VSCode and terminal did not have accessibility or screen recording permissions
• Tested changes with npm test on active-win project
• Tested on my electron app in dev and prod environment by compiling active-win locally and pasting the main file unto my electron apps' node_modules/active-win directory

Disclaimer

Please note that while I am not a Swift developer by profession, I have taken care to ensure that the changes proposed in this pull request adhere to best practices to the best of my knowledge and have been thoroughly tested.

[kentbetita]

We could also update the condition from getWindowInformation for consistency:

// Run the AppleScript to get the URL if the active window is a compatible browser and accessibility permissions are enabled.
if !disableAccessibilityPermission {
	if let bundleIdentifier = app.bundleIdentifier,
	   let script = getActiveBrowserTabURLAppleScriptCommand(bundleIdentifier),
	   let url = runAppleScript(source: script) {
		output["url"] = url
	}
}

but from my testing it has been working fine for both cases. This is optional.