Give API access to FileTypeParser#detectors
#704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borewit
added
enhancement
Borewit
force-pushed
the
grant-access-detector-array
branch
from
bd85412 to
f08c857
Compare
sindresorhus
requested changes
Dec 16, 2024
sindresorhus
requested changes
Dec 16, 2024
Borewit
force-pushed
the
grant-access-detector-array
branch
3 times, most recently
from
4b27ec9 to
3fdd033
Compare
Borewit
added
the
API change
sindresorhus
requested changes
Dec 18, 2024
This gives the user more control to determine the sequence of detectors. Resolves: #628
Borewit
force-pushed
the
grant-access-detector-array
branch
2 times, most recently
from
e59f6a0 to
cd992e9
Compare
Use hash for class method member reference. Simplify code comments. Co-authored-by: Sindre Sorhus <[email protected]>
Borewit
force-pushed
the
grant-access-detector-array
branch
from
cd992e9 to
4b3d9fb
Compare
|
Still out of sync: https://github.com/sindresorhus/file-type/pull/704/files#diff-5a831ea67cf5cf8703b0de46901ab25bd191f56b320053be9332d9a3b0d01d15R343 The |
sindresorhus
changed the title
FileTypeParser.detectorsFileTypeParser#detectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives the user more control to determine the sequence of detectors.
API change:
FileTypeParser.detectorschanged fromIterable<Detector>toDetector[].Resolves: #628