Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test fixtures for line breaks support. #112

Closed
wants to merge 1 commit into from
Closed

Add test fixtures for line breaks support. #112

wants to merge 1 commit into from

Conversation

kdeldycke
Copy link
Contributor

@kdeldycke kdeldycke commented Jul 27, 2020

This is a proposal to allow for line breaks in both link titles and descriptions.

I updated the fixtures to demonstrate the feature I look forward to implement. Of course tests are failing. But if the community validates that format, I can update that PR to implement the corresponding rules.

@sindresorhus
Copy link
Owner

Thanks for the suggestion, but that's intentional. Forced-linebreaks are contributor-hostile. A single word change could potentially force a user to manually have to reflow lines, which is especially painful when contributing in the GitHub web UI editor.

@kdeldycke
Copy link
Contributor Author

OK, I understand your point of view. I was also concerned about that one too.

In the last few weeks I tried not only to automate linting by the way of GitHub Actions, but also autofix and format Mardown. Which is a featured requested at #103.

I played with tools like pandoc and cmark, and I think we can delegate the hard work of reflowing the content to these CLIs.

My goal is to deploy a forgiving workflow, in which contributors will not have to bother reflowing content. An auto-formatting commit might be applied to any new PR or change. We're not that far from a dream setup in which neither contributors or maintainers will not have to worry too much about nitpicking! 😉

Anyway, no offense taken closing that PR. I'll keep applying the current rules and work towards auto-reflow on the side. Thanks @sindresorhus for the reply! 👍

@kdeldycke kdeldycke deleted the new-line-whitespacing branch July 27, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants