Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Class Modules to define DungeonSlice #7478

Draft
wants to merge 3 commits into
base: dragonflight
Choose a base branch
from
Draft

Allow Class Modules to define DungeonSlice #7478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acc480a
Add init_dungeon_fight_style()
JeremyMonk Mar 29, 2023
492d6f5
Allow modules to define DungeonSlice
JeremyMonk Mar 29, 2023
005b8d0
Virtual void definition
JeremyMonk Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions engine/player/player.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14473,3 +14473,19 @@ bool player_t::is_ptr() const
{
return maybe_ptr(dbc->ptr);
}

void player_t::init_dungeon_fight_style( sim_t *sim )
{
// Based on the Hero Dungeon setup
sim->desired_targets = 1;
sim->max_time = timespan_t::from_seconds( 360.0 );

sim->shadowlands_opts.enable_rune_words = false;
sim->ignore_invulnerable_targets = true;

sim->raid_events_str +=
"/invulnerable,cooldown=500,duration=500,retarget=1"
"/adds,name=Boss,count=1,cooldown=500,duration=135,type=add_boss,duration_stddev=1"
"/adds,name=SmallAdd,count=5,count_range=1,first=140,cooldown=45,duration=15,duration_stddev=2"
"/adds,name=BigAdd,count=2,count_range=1,first=160,cooldown=50,duration=30,duration_stddev=2";
}
1 change: 1 addition & 0 deletions engine/player/player.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,6 +937,7 @@ struct player_t : public actor_t
virtual void create_buffs();
virtual void create_special_effects();
virtual void init_special_effects();
virtual void init_dungeon_fight_style( sim_t *sim );
/// Modify generic special effect initialization
///
/// Intended to allow modifications to some aspects of the special effect (or buffs,
Expand Down
13 changes: 1 addition & 12 deletions engine/sim/sim.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2261,18 +2261,7 @@ void sim_t::init_fight_style()
break;

case FIGHT_STYLE_DUNGEON_SLICE:
//Based on the Hero Dungeon setup
desired_targets = 1;
max_time = timespan_t::from_seconds( 360.0 );

shadowlands_opts.enable_rune_words = false;
ignore_invulnerable_targets = true;

raid_events_str +=
"/invulnerable,cooldown=500,duration=500,retarget=1"
"/adds,name=Boss,count=1,cooldown=500,duration=135,type=add_boss,duration_stddev=1"
"/adds,name=SmallAdd,count=5,count_range=1,first=140,cooldown=45,duration=15,duration_stddev=2"
"/adds,name=BigAdd,count=2,count_range=1,first=160,cooldown=50,duration=30,duration_stddev=2";
active_player->init_dungeon_fight_style( this );
break;

case FIGHT_STYLE_DUNGEON_ROUTE:
Expand Down