Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor package removal #67

Merged
merged 4 commits into from
May 24, 2022
Merged

Honor package removal #67

merged 4 commits into from
May 24, 2022

Conversation

trevor-vaughan
Copy link
Member

  • Ensure that the module does not manage files if the package is being removed
  • Added .rubocop.yml

Closes #66

@trevor-vaughan
Honor package removal
607c276 
* Ensure that the module does not manage files if the package is being removed
* Added .rubocop.yml

Closes simp#66
@trevor-vaughan trevor-vaughan mentioned this pull request May 20, 2022
Closed
op-ct
op-ct approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@op-ct op-ct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pattern is not followed by other modules in the framework

@op-ct
Copy link
Member

op-ct commented May 24, 2022

Cleaned up timed-out pup7 GLCI job; now merging

@op-ct op-ct merged commit a941c49 into simp:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@op-ct op-ct op-ct approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The xinetd module should not manage files if $package_ensure == absent
2 participants
@trevor-vaughan @op-ct